glibc

Tree: 900fa25736

Adhemerval Zanella 3a0588ae48 elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868 ) On _dl_map_object the underlying file is not opened in trace mode (in other cases where the underlying file can't be opened, _dl_map_object quits with an error). If there any missing libraries being processed, they will not be considered on final nlist size passed on _dl_sort_maps later in the function. And it is then used by _dl_sort_maps_dfs on the stack allocated working maps: 222 /* Array to hold RPO sorting results, before we copy back to maps[]. / 223 struct link_map rpo[nmaps]; 224 225 /* The 'head' position during each DFS iteration. Note that we start at 226 one past the last element due to first-decrement-then-store (see the 227 bottom of above dfs_traversal() routine). / 228 struct link_map *rpo_head = &rpo[nmaps]; However while transversing the 'l_initfini' on dfs_traversal it will still consider the l_faked maps and thus update rpo more times than the allocated working 'rpo', overflowing the stack object. As suggested in bugzilla, one option would be to avoid sorting the maps for trace mode. However I think ignoring l_faked object does make sense (there is one less constraint to call the sorting function), it allows a slight less stack usage for trace, and it is slight simpler solution. The tests does trigger the stack overflow, however I tried to make it more generic to check different scenarios or missing objects. Checked on x86_64-linux-gnu. Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>		4 years ago
..
abi-versions.awk	Remove bitrotten --enable-oldest-abi (bug 6652).	12 years ago
abilist.awk	Add GLIBC_ABI_DT_RELR for DT_RELR support	4 years ago
backport-support.sh	Update copyright dates with scripts/update-copyrights	4 years ago
build-many-glibcs.py	Use Linux 5.17 in build-many-glibcs.py	4 years ago
check-c++-types.sh	Update copyright dates with scripts/update-copyrights	4 years ago
check-execstack.awk	check-execstack: Permit sysdeps to xfail some libs	8 years ago
check-initfini.awk	Update copyright dates with scripts/update-copyrights	4 years ago
check-installed-headers.sh	Update copyright dates with scripts/update-copyrights	4 years ago
check-local-headers.sh	Update copyright dates with scripts/update-copyrights	4 years ago
check-localplt.awk	Extend local PLT reference check	11 years ago
check-obsolete-constructs.py	Update copyright dates with scripts/update-copyrights	4 years ago
check-textrel.awk	Do check-textrel test using readelf rather than a build-time C program.	14 years ago
check-wrapper-headers.py	Update copyright dates with scripts/update-copyrights	4 years ago
check-wx-segment.py	Update copyright dates with scripts/update-copyrights	4 years ago
config-uname.sh	Rejigger header generation for default uname implementation.	16 years ago
config.guess	Update miscellaneous files from upstream sources.	7 years ago
config.sub	Update miscellaneous files from upstream sources.	7 years ago
cpp	Make shebang interpreter directives consistent	10 years ago
cross-test-ssh.sh	Update copyright dates with scripts/update-copyrights	4 years ago
documented.sh	Make shebang interpreter directives consistent	10 years ago
dso-ordering-test.py	scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing	4 years ago
evaluate-test.sh	Update copyright dates with scripts/update-copyrights	4 years ago
firstversions.awk	Fix bug in firstversions.awk version range handling.	14 years ago
gen-as-const.py	Update copyright dates with scripts/update-copyrights	4 years ago
gen-libc-abis	Make shebang interpreter directives consistent	10 years ago
gen-libc-modules.awk	Auto-generate libc-modules.h	12 years ago
gen-posix-conf-vars.awk	Remove uses of sprintf in gen-posix-conf-vars.awk	11 years ago
gen-rrtypes.py	Update copyright dates with scripts/update-copyrights	4 years ago
gen-sorted.awk	Update copyright dates with scripts/update-copyrights	4 years ago
gen-tunables.awk	elf: Avoid RELATIVE relocs in __tunables_init	5 years ago
glibc_shared_code.py	Update copyright dates with scripts/update-copyrights	4 years ago
glibcelf.py	elf: Define DT_RELR related macros and types	4 years ago
glibcextract.py	Update copyright dates with scripts/update-copyrights	4 years ago
glibcsymbols.py	Update copyright dates with scripts/update-copyrights	4 years ago
haveversions.awk	Don't build libnsl for new ABIs	8 years ago
install-sh	Update miscellaneous files from upstream sources.	7 years ago
lib-names.awk	Clean up gnu/lib-names.h generation (bug 14171).	12 years ago
list-fixed-bugs.py	Update copyright dates with scripts/update-copyrights	4 years ago
list-sources.sh	Update scripts/list-sources.sh for ports repository merge.	12 years ago
localplt.awk	Support PLT and GOT references in local PIC check	11 years ago
merge-test-results.sh	Update copyright dates with scripts/update-copyrights	4 years ago
mkinstalldirs	Update miscellaneous files from upstream sources.	7 years ago
move-if-change	Sync move-if-change from Gnulib, updating copyright	4 years ago
move-symbol-to-libc.py	Update copyright dates with scripts/update-copyrights	4 years ago
pylint	Implement benchmarking script in python	12 years ago
pylintrc	pylintrc: disable reports	11 years ago
rellns-sh	Update copyright dates with scripts/update-copyrights	4 years ago
soversions.awk	Remove bitrotten --enable-oldest-abi (bug 6652).	12 years ago
sysd-rules.awk	sysd-rules: Cut down the number of rtld-% pattern rules	10 years ago
test-installation.pl	Update copyright dates not handled by scripts/update-copyrights.	4 years ago
test_printers_common.py	Disable debuginfod in printer tests [BZ #28757]	4 years ago
test_printers_exceptions.py	Update copyright dates with scripts/update-copyrights	4 years ago
tst-elf-edit.py	elf: Replace tst-p_alignmod1-editX with a python script	4 years ago
tst-ld-trace.py	elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868)	4 years ago
update-abilist.sh	Update copyright dates with scripts/update-copyrights	4 years ago
update-copyrights	Update copyright dates with scripts/update-copyrights	4 years ago
vcstocl_quirks.py	Update copyright dates with scripts/update-copyrights	4 years ago
versionlist.awk	Update copyright dates with scripts/update-copyrights	4 years ago
versions.awk	Add GLIBC_ABI_DT_RELR for DT_RELR support	4 years ago