glibc

Tree: 4a39c34c4f

Zack Weinberg 4a39c34c4f Change most internal uses of __gettimeofday to __clock_gettime. Since gettimeofday will shortly be implemented in terms of clock_gettime on all platforms, internal code should use clock_gettime directly; in addition to removing a layer of indirection, this will allow us to remove the PLT-bypass gunk for gettimeofday. (We can't quite do that yet, but it'll be coming later in this patch series.) In many cases, the changed code does fewer conversions. The changed code always assumes __clock_gettime (CLOCK_REALTIME) cannot fail. Most of the call sites were assuming gettimeofday could not fail, but a few places were checking for errors. POSIX says clock_gettime can only fail if the clock constant is invalid or unsupported, and CLOCK_REALTIME is the one and only clock constant that's required to be supported. For consistency I grepped the entire source tree for any other places that checked for errors from __clock_gettime (CLOCK_REALTIME), found one, and changed it too. (For the record, POSIX also says gettimeofday can never fail.) (It would be nice if we could declare that GNU systems will always support CLOCK_MONOTONIC as well as CLOCK_REALTIME; there are several places where we are using CLOCK_REALTIME where _MONOTONIC would be more appropriate, and/or trying to use _MONOTONIC and then falling back to _REALTIME. But the Hurd doesn't support CLOCK_MONOTONIC yet, and it looks like adding it would involve substantial changes to gnumach's internals and API. Oh well.) A few Hurd-specific files were changed to use __host_get_time instead of __clock_gettime, as this seemed tidier. We also assume this cannot fail. Skimming the code in gnumach leads me to believe the only way it could fail is if __mach_host_self also failed, and our Hurd-specific code consistently assumes that can't happen, so I'm going with that. With the exception of support/support_test_main.c, test cases are not modified, mainly because I didn't want to have to figure out which test cases were testing gettimeofday specifically. The definition of GETTIME in sysdeps/generic/memusage.h had a typo and was not reading tv_sec at all. I fixed this. It appears nobody has been generating malloc traces on a machine that doesn't have a superseding definition. There are a whole bunch of places where the code could be simplified by factoring out timespec subtraction and/or comparison logic, but I want to keep this patch as mechanical as possible. Checked on x86_64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu, powerpc64-linux-gnu, powerpc-linux-gnu, and aarch64-linux-gnu. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Reviewed-by: Lukasz Majewski <lukma@denx.de>		7 years ago
..
Makefile	NPTL: Refactor named semaphore code to use shm-directory.h	11 years ago
Subdirs	Make sysdeps/posix bring in login subdir.	11 years ago
alarm.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
clock.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
clock_getres.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
closedir.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
ctermid.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
cuserid.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
dirfd.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
dirstream.h	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
dl-fileid.h	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
dup.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
dup2.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
euidaccess.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
fdopendir.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
flock.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
fpathconf.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
gai_strerror-strs.h	* sysdeps/posix/gai_strerror.c: Complete rewrite. Avoid relocations.	21 years ago
gai_strerror.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
getaddrinfo.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
getcwd.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
getdtsz.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
gethostname.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
getpagesize.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
gettimeofday.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
isatty.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
isfdtype.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
killpg.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
libc_fatal.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
mkfifo.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
mkfifoat.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
nice.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
open64.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
opendir.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pathconf.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pause.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
posix_fallocate.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
posix_fallocate64.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pread.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pread64.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
preadv.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
preadv2.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
preadv64.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
preadv64v2.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
preadv_common.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
profil.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pwrite.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pwrite64.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pwritev.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pwritev2.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pwritev64.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pwritev64v2.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
pwritev_common.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
raise.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
readdir.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
readdir_r.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
readv.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
remove.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
rename.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
rewinddir.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
seekdir.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
shm-directory.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
shm-directory.h	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
shm_open.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
shm_unlink.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigblock.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigignore.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigintr.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
signal.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigpause.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigset.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigsetmask.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigsuspend.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sigwait.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sleep.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
spawni.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sprofil.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sysconf.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
system.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
sysv_signal.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
telldir.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
tempname.c	Change most internal uses of __gettimeofday to __clock_gettime.	7 years ago
time.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
timespec_get.c	Change most internal uses of __gettimeofday to __clock_gettime.	7 years ago
truncate.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
ttyname.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
ttyname_r.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
ulimit.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
usleep.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
utime.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
utimes.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
wait.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
wait3.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
waitid.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago
writev.c	Prefer https to http for gnu.org and fsf.org URLs	7 years ago