Browse Source

tests: Replace various function calls with their x variant

With fortification enabled, few function calls return result need to be
checked, has they get the __wur macro enabled.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
azanella/bz30558-posix_timer
Frédéric Bérat 3 years ago
committed by Siddhesh Poyarekar
parent
commit
f6a532fbd0
  1. 4
      misc/tst-error1.c
  2. 2
      nss/tst-reload2.c
  3. 7
      posix/tst-chmod.c
  4. 2
      posix/wordexp-test.c
  5. 4
      stdlib/test-canon.c

4
misc/tst-error1.c

@ -5,11 +5,13 @@
#include <wchar.h>
#include <libc-diag.h>
#include <support/xstdio.h>
static int
do_test (int argc, char *argv[])
{
mtrace ();
(void) freopen (argc == 1 ? "/dev/stdout" : argv[1], "a", stderr);
xfreopen (argc == 1 ? "/dev/stdout" : argv[1], "a", stderr);
/* Orient the stream. */
fwprintf (stderr, L"hello world\n");
char buf[20000];

2
nss/tst-reload2.c

@ -121,7 +121,7 @@ do_test (void)
/* Change the root dir. */
TEST_VERIFY (chroot ("/subdir") == 0);
chdir ("/");
xchdir ("/");
/* Check we're NOT using the "inner" nsswitch.conf. */

7
posix/tst-chmod.c

@ -27,6 +27,8 @@
#include <unistd.h>
#include <sys/stat.h>
#include <support/xunistd.h>
#define OUT_OF_MEMORY \
do { \
@ -229,7 +231,8 @@ do_test (int argc, char *argv[])
close (fd);
snprintf (buf, buflen, "%s/..", testdir);
chdir (buf);
xchdir (buf);
/* We are now in the directory above the one we create the test
directory in. */
@ -349,7 +352,7 @@ do_test (int argc, char *argv[])
}
fail:
chdir (startdir);
xchdir (startdir);
/* Remove all the files. */
chmod (testdir, 0700);

2
posix/wordexp-test.c

@ -336,7 +336,7 @@ do_test (int argc, char *argv[])
if (cwd == NULL)
cwd = "..";
chdir (cwd);
xchdir (cwd);
rmdir (tmpdir);
return 0;

4
stdlib/test-canon.c

@ -27,6 +27,8 @@
#include <sys/param.h>
#include <sys/stat.h>
#include <support/xunistd.h>
/* Prototype for our test function. */
extern int do_test (int argc, char *argv[]);
#include <test-skeleton.c>
@ -159,7 +161,7 @@ do_test (int argc, char ** argv)
}
for (i = 0; i < (int) (sizeof (symlinks) / sizeof (symlinks[0])); ++i)
symlink (symlinks[i].value, symlinks[i].name);
xsymlink (symlinks[i].value, symlinks[i].name);
int has_dir = mkdir ("doesExist", 0777) == 0;

Loading…
Cancel
Save