* lib/remote.exp (standard_load): Fix typo on empty string.

* runtest.exp: Adjust expression to follow GNU conventions.
	* lib/utils.exp (diff): Fix mistake in replacing [string compare]
	with "eq" instead of "ne".
	* testsuite/runtest.all/config.test: Likewise.

Signed-off-by: Ben Elliston <bje@gnu.org>

ChangeLog

@@ -1,3 +1,11 @@
+2018-12-06  Jacob Bachmeyer  <jcb62281@gmail.com>
+
+	* lib/remote.exp (standard_load): Fix typo on empty string.
+	* runtest.exp: Adjust expression to follow GNU conventions.
+	* lib/utils.exp (diff): Fix mistake in replacing [string compare]
+	with "eq" instead of "ne".
+	* testsuite/runtest.all/config.test: Likewise.
+
 2018-12-06  Ben Elliston  <bje@gnu.org>
 
 	* runtest.exp: Replace [string match] commands involving literal

lib/remote.exp

@@ -1107,7 +1107,7 @@ proc standard_load { dest prog args } {
     set status [lindex $status 0]
 
     verbose -log "Executed $prog, status $status" 2
-    if {$output ne ''} {
+    if { $output ne "" } {
 	verbose -log -- "$output" 2
     }
     if { $status == 0 } {

lib/utils.exp

@@ -352,7 +352,7 @@ proc diff { file_1 file_2 } {
 	set line_a [lindex ${list_a} ${i}]
 	set line_b [lindex ${list_b} ${i}]
 
-	if {$line_a eq $line_b} {
+	if {$line_a ne $line_b} {
 	    verbose -log "line #${i}" 2
 	    verbose -log "\< ${line_a}" 2
 	    verbose -log "\> ${line_b}" 2

runtest.exp

@@ -1727,8 +1727,8 @@ foreach current_target $target_list {
 	    set temp_top_dirs ""
 	    set prev_dir ""
 	    foreach dir "${test_top_dirs}" {
-		if {$prev_dir eq "" || \
-			[string first "${prev_dir}/" ${dir}] == -1} {
+		if { $prev_dir eq ""
+		     || [string first "${prev_dir}/" ${dir}] == -1 } {
 		    # the first top dir entry, or an entry that
 		    # does not share the previous entry's entire
 		    # pathname, record it as a valid top dir entry.

testsuite/runtest.all/config.test

@@ -53,7 +53,7 @@ if [isbuild hppa-ibm-macos ] {
 }
 
 # test default argument for isbuild
-if {[isbuild] eq $build_triplet} {
+if {[isbuild] ne $build_triplet} {
    puts "FAILED: isbuild with no arguments"
 } else {
    puts "PASSED: isbuild with no arguments"
@@ -79,7 +79,7 @@ if [ishost hppa-ibm-macos] {
 }
 
 # test default argument for ishost
-if {[ishost] eq $host_triplet} {
+if {[ishost] ne $host_triplet} {
    puts "FAILED: ishost with no arguments"
 } else {
    puts "PASSED: ishost with no arguments"
@@ -105,7 +105,7 @@ if [istarget hppa-ibm-macos] {
 }
 
 # test default argument for istarget
-if {[istarget] eq $target_triplet} {
+if {[istarget] ne $target_triplet} {
    puts "FAILED: istarget with no arguments"
 } else {
    puts "PASSED: istarget with no arguments"