binutils-gdb

History

Simon Marchi f08708cbf5 sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary I finally got the all-targets sim building with Clang, these are all the instances where an ATTRIBUTE_PRINTF or ATTRIBUTE_NULL_PRINTF attribute needed to be added to avoid errors like: /home/simark/src/binutils-gdb/sim/aarch64/../common/sim-profile.c:464:19: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf (fp, fmt, ap); ^~~ There are more fixes needed to get everything building, but adding these attributes is trivial enough, so I send them all in a single patch. Adding the format attributes introduces some format string errors when building with GCC (because now format strings are checked), so corresponding changes are needed to avoid breaking the build. Other than simple format string specified changes, there is this one: /home/simark/src/binutils-gdb/sim/aarch64/../common/hw-events.c: In function 'hw_event_queue_schedule': /home/simark/src/binutils-gdb/sim/aarch64/../common/hw-events.c:95:15: error: too many arguments for format [-Werror=format-extra-args] 95 \| NULL, dummy); \| ^~~~~ We can fix it and avoid using a dummy variable by simply calling hw_event_queue_schedule_tracef instead of hw_event_queue_schedule_vtracef. sim/arm/ChangeLog: * armdefs.h (ARMul_ConsolePrint): Use format attribute. * wrapper.c (op_printf): Likewise. sim/bfin/ChangeLog: * interp.c (sim_open): Adjust format string specifier. sim/common/ChangeLog: * hw-events.h (hw_event_queue_schedule_tracef): Use format attribute. (hw_event_queue_schedule_vtracef): Likewise. * hw-tree.h (hw_tree_vparse): Likewise. * sim-profile.c (profile_vprintf): Likewise. * sim-trace.c (dis_printf): Likewise. * sim-trace.h (trace_printf): Likewise. (trace_vprintf): Likewise. * sim-utils.h (sim_do_commandf): Likewise. * hw-events.c (hw_event_queue_schedule): Use hw_event_queue_schedule_tracef. sim/rx/ChangeLog: * trace.c (op_printf): Likewise. sim/v850/ChangeLog: * interp.c (sim_open): Adjust format string specifier. Change-Id: I1445115ce57db15bb8e35dca93014555e7555794		5 years ago
..
aarch64	sim: nrun: add local strsignal prototype	5 years ago
arm	sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary	5 years ago
avr	sim: nrun: add local strsignal prototype	5 years ago
bfin	sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary	5 years ago
bpf	sim: nrun: add local strsignal prototype	5 years ago
common	sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary	5 years ago
cr16	sim: nrun: add local strsignal prototype	5 years ago
cris	sim: nrun: add local strsignal prototype	5 years ago
d10v	sim: nrun: add local strsignal prototype	5 years ago
erc32	sim: nrun: add local strsignal prototype	5 years ago
example-synacor	sim: nrun: add local strsignal prototype	5 years ago
frv	sim: nrun: add local strsignal prototype	5 years ago
ft32	sim: nrun: add local strsignal prototype	5 years ago
h8300	sim: nrun: add local strsignal prototype	5 years ago
igen	sim: replace custom attributes with ansidecl.h	5 years ago
iq2000	sim: nrun: add local strsignal prototype	5 years ago
lm32	sim: nrun: add local strsignal prototype	5 years ago
m4	sim: nrun: add local strsignal prototype	5 years ago
m32c	sim: replace custom attributes with ansidecl.h	5 years ago
m32r	sim: nrun: add local strsignal prototype	5 years ago
m68hc11	sim: nrun: add local strsignal prototype	5 years ago
mcore	sim: nrun: add local strsignal prototype	5 years ago
microblaze	sim: nrun: add local strsignal prototype	5 years ago
mips	sim: mips: mark local func static	5 years ago
mn10300	sim: nrun: add local strsignal prototype	5 years ago
moxie	sim: nrun: add local strsignal prototype	5 years ago
msp430	sim: nrun: add local strsignal prototype	5 years ago
or1k	sim: nrun: add local strsignal prototype	5 years ago
ppc	Do not check for sys/time.h or sys/times.h	5 years ago
pru	sim: nrun: add local strsignal prototype	5 years ago
riscv	sim: nrun: add local strsignal prototype	5 years ago
rl78	sim: nrun: add local strsignal prototype	5 years ago
rx	sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary	5 years ago
sh	sim: nrun: add local strsignal prototype	5 years ago
testsuite	sim: syscall: add getpid support	5 years ago
v850	sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary	5 years ago
.gitignore	sim: drop common/cconfig.h in favor of a single config.h	10 years ago
ChangeLog	sim: nrun: add local strsignal prototype	5 years ago
MAINTAINERS	sim: readd myself as a maintainer	5 years ago
Makefile.am	sim: testsuite: integrate common tests into build	5 years ago
Makefile.in	sim: testsuite: integrate common tests into build	5 years ago
README-HACKING	sim: nltvals: unify common syscall tables	5 years ago
aclocal.m4	sim: unify toolchain settings	5 years ago
configure	sim: example-synacor: a simple implementation for reference	5 years ago
configure.ac	sim: example-synacor: a simple implementation for reference	5 years ago