binutils-gdb

History

Nelson Chu ef9d256562 RISC-V: PR27566, Do not relax when data segment phase is exp_seg_relro_adjust. 2021-05-31 Nelson Chu <nelson.chu@sifive.com> Lifang Xia <lifang_xia@c-sky.com> The data segment phase exp_seg_relro_adjust means we are still adjusting the relro segments, so we will get the symbol values which havn't consider the relro. It is dangerous and we shouldn't do the relaxations at this stage. Otherwise, we may get the truncated fails when the relax range crossing the data segment. One of the solution is that, we use a pointer to monitor the data segment phase while relaxing, to know whether the relro has been handled or not. Once we check the phase is exp_seg_relro_adjust, we should skip this round of relaxations, since the incorrect symbol values will affect the correctness of relaxations. I think we probably need to record more information about data segment or alignments in the future, to make sure it is safe to doing relaxations. For the two new testcases, relro-relax-lui and relro-relax-pcrel, we get the following truncated errors when using toolchains, which enable relro: (.text+0x0): relocation truncated to fit: R_RISCV_GPREL_I against symbol `SymbolRodata' defined in .rodata section in test1.o After applying this patch, the truncated errors should be resolved. However, only linux toolchains support -z relro, so we only test these two testcases when supporting shared library. bfd/ PR 27566 * elfnn-riscv.c (struct riscv_elf_link_hash_table): New integer pointer to monitor the data segment phase. (bfd_elfNN_riscv_set_data_segment_info): New function called by after_allocation, to set the data_segment_phase from expld.dataseg. (_bfd_riscv_relax_section): Don't relax when data_segment_phase is exp_seg_relro_adjust (0x4). * elfxx-riscv.h (bfd_elf32_riscv_set_data_segment_info): New extern. (bfd_elf64_riscv_set_data_segment_info): Likewise. ld/ PR 27566 * emultempl/riscvelf.em (after_allocation): Call riscv_set_data_segment_info to set data segment phase before relaxing. * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated. * testsuite/ld-riscv-elf/relro-relax-lui.d: New testcase. * testsuite/ld-riscv-elf/relro-relax-lui.s: Likewise. * testsuite/ld-riscv-elf/relro-relax-pcrel.d: Likewise. * testsuite/ld-riscv-elf/relro-relax-pcrel.s: Likewise.		5 years ago
..
README	Update year range in copyright notice of binutils files	6 years ago
aarch64elf.em	Use bool in ld	5 years ago
aix.em	Use bool in ld	5 years ago
alphaelf.em	Use bool in ld	5 years ago
arclinux.em	Update year range in copyright notice of binutils files	6 years ago
armcoff.em	Use bool in ld	5 years ago
armelf.em	PR27719, lang_mark_undefineds trashes memory	5 years ago
astring.sed	* emultempl/ostring.sed: Rename from stringify.sed.	27 years ago
avrelf.em	Use bool in ld	5 years ago
beos.em	Use bool in ld	5 years ago
bfin.em	Use bool in ld	5 years ago
cr16elf.em	Use bool in ld	5 years ago
crxelf.em	Use bool in ld	5 years ago
cskyelf.em	Use bool in ld	5 years ago
elf-generic.em	Update year range in copyright notice of binutils files	6 years ago
elf-x86.em	Update year range in copyright notice of binutils files	6 years ago
elf.em	Use bool in ld	5 years ago
epiphanyelf_4x4.em	Update year range in copyright notice of binutils files	6 years ago
genelf.em	Use bool in ld	5 years ago
generic.em	Update year range in copyright notice of binutils files	6 years ago
hppaelf.em	Use bool in ld	5 years ago
ia64elf.em	Update year range in copyright notice of binutils files	6 years ago
irix.em	Update year range in copyright notice of binutils files	6 years ago
linux.em	Use bool in ld	5 years ago
m68hc1xelf.em	Use bool in ld	5 years ago
m68kelf.em	Update year range in copyright notice of binutils files	6 years ago
metagelf.em	Use bool in ld	5 years ago
mipself.em	convert elf_link_hash macros to inline functions	5 years ago
mmix-elfnmmo.em	Use bool in ld	5 years ago
mmixelf.em	Use bool in ld	5 years ago
mmo.em	Use bool in ld	5 years ago
msp430.em	Use bool in ld	5 years ago
nds32elf.em	Remove bfd_stdint.h	5 years ago
needrelax.em	Update year range in copyright notice of binutils files	6 years ago
netbsd.em	Update year range in copyright notice of binutils files	6 years ago
nios2elf.em	Use bool in ld	5 years ago
ostring.sed	* emultempl/ostring.sed: Rename from stringify.sed.	27 years ago
pdp11.em	Use bool in ld	5 years ago
pe.em	Use bool in ld	5 years ago
pep.em	Use bool in ld	5 years ago
ppc32elf.em	Use bool in ld	5 years ago
ppc64elf.em	Use bool in ld	5 years ago
pruelf.em	Update year range in copyright notice of binutils files	6 years ago
riscvelf.em	RISC-V: PR27566, Do not relax when data segment phase is exp_seg_relro_adjust.	5 years ago
rxelf.em	Use bool in ld	5 years ago
rxlinux.em	Use bool in ld	5 years ago
s390.em	Update year range in copyright notice of binutils files	6 years ago
scoreelf.em	Use bool in ld	5 years ago
solaris2-x86.em	Update year range in copyright notice of binutils files	6 years ago
solaris2.em	PR27719, lang_mark_undefineds trashes memory	5 years ago
spu_icache.S	bfd/	18 years ago
spu_icache.o_c	Regenerate spu overlay and icache manager files	12 years ago
spu_ovl.S	Update year range in copyright notice of binutils files	6 years ago
spu_ovl.o_c	Regenerate spu_ovl.o_c	10 years ago
spuelf.em	Use bool in ld	5 years ago
tic6xdsbt.em	Update year range in copyright notice of binutils files	6 years ago
ticoff.em	Use bool in ld	5 years ago
v850elf.em	Use bool in ld	5 years ago
vanilla.em	Update year range in copyright notice of binutils files	6 years ago
vms.em	Use bool in ld	5 years ago
vxworks.em	Update year range in copyright notice of binutils files	6 years ago
xtensaelf.em	Use bool in ld	5 years ago
z80.em	Use bool in ld	5 years ago

README

The files in this directory are sourced by genscripts.sh, after
setting some variables to substitute in, to produce
C source files that contain jump tables for each emulation.

Copyright (C) 2012-2021 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.