binutils-gdb

Tree: 775d36a916

History

Nick Alcock 6ab5b6d0f3 libctf, lookup: fix bounds of pptrtab lookup An off-by-one bug in the check for pptrtab lookup meant that we could access the pptrtab past its bounds (well past its bounds), particularly if we called ctf_lookup_by_name in a child dict with "foo" where "foo" is a type that exists in the parent but not the child and no previous lookups by name have been carried out. (Note that "foo" is not even a valid thing to call ctf_lookup_by_name with: foo * is. Nonetheless, users sometimes do call ctf_lookup_by_name with invalid content, and it should return ECTF_NOTYPE, not crash.) ctf_pptrtab_len, as its name suggests (and as other tests of it in ctf-lookup.c confirm), is one higher than the maximum valid permissible index, so the comparison is wrong. (Test added, which should fail pretty reliably in the presence of this bug on any machine with 4KiB pages.) libctf/ChangeLog 2021-09-27 Nick Alcock <nick.alcock@oracle.com> * ctf-lookup.c (ctf_lookup_by_name_internal): Fix pptrtab bounds. * testsuite/libctf-writable/pptrtab-writable-page-deep-lookup.*: New test.		5 years ago
..
config	CC_FOR_TARGET et al	5 years ago
lib	CC_FOR_TARGET et al	5 years ago
libctf-lookup	libctf, testsuite: fix various warnings in tests	5 years ago
libctf-regression	libctf, testsuite: fix various warnings in tests	5 years ago
libctf-writable	libctf, lookup: fix bounds of pptrtab lookup	5 years ago