binutils-gdb

History

Andrew Burgess c5ebe0ff70 sim: Don't overwrite stored errno in sim_syscall_multi The host syscall callback mechanism should take care of updating the errcode within the CB_SYSCALL struct, and we should not be adjusting the error code once the syscall has completed. We especially, should not be rewriting the syscall errcode based on the value of errno some time after running the host syscall, as there is no guarantee that errno has not be overwritten. To perform a syscall we call cb_syscall (in syscall.c). To return from cb_syscall control passes through one of two exit paths these are labeled FinishSyscall and ErrorFinish and are reached using goto statements scattered throughout the cb_syscall function. In FinishSyscall we store the syscall result in 'sc->result', and the error code is transated to target encoding, and stored in 'sc->errcode'. In ErrorFinish, we again store the syscall result in 'sc->result', and fill in 'sc->errcode' by fetching the actual errno from the host with the 'cb->get_errno' callback. In both cases 'sc->errcode' will have been filled in with an appropriate value. Further, if we look at a specific syscall example, CB_SYS_open, in this case the first thing we do is fetch the path to open from the target with 'get_path', if this fails then the errcode is returned, and we jump to FinishSyscall. Notice that in this case, no host syscall may have been performed, for example a failure to read the path to open out of simulated memory can return EINVAL without performing any host syscall. Given that no host syscall has been performed, reading the host errno makes absolutely no sense. This commit removes from sim_syscall_multi the rewriting of sc->errcode based on the value of errno, and instead relies on the value stored in the cb_syscall. sim/common/ChangeLog: * sim-syscall.c (sim_syscall_multi): Don't update sc->errcode at this point, it should have already been set in cb_syscall.		8 years ago
..
aarch64	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
arm	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
avr	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
bfin	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
common	sim: Don't overwrite stored errno in sim_syscall_multi	7 years ago
cr16	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
cris	sim/cris: Fix references to cgen cpu directory	7 years ago
d10v	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
erc32	[src/erc32] Use ncurses instead of termcap on Cygwin too	8 years ago
frv	sim/opcodes: Allow use of out of tree cgen source directory	7 years ago
ft32	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
h8300	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
igen	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
iq2000	sim/opcodes: Allow use of out of tree cgen source directory	7 years ago
lm32	sim/opcodes: Allow use of out of tree cgen source directory	7 years ago
m32c	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
m32r	sim/opcodes: Allow use of out of tree cgen source directory	7 years ago
m68hc11	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
mcore	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
microblaze	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
mips	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
mn10300	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
moxie	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
msp430	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
or1k	sim/opcodes: Allow use of out of tree cgen source directory	7 years ago
ppc	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
rl78	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
rx	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
sh	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
sh64	sim/opcodes: Allow use of out of tree cgen source directory	7 years ago
testsuite	or1k: Add the l.muld, l.muldu, l.macu, l.msbu insns	8 years ago
v850	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
.gitignore	sim: drop common/cconfig.h in favor of a single config.h	10 years ago
ChangeLog	sim/opcodes: Allow use of out of tree cgen source directory	7 years ago
MAINTAINERS	Update my e-mail address, limit maintenance to MIPS I-IV ISAs	8 years ago
Makefile.in	Update copyright year range in all GDB files	8 years ago
README-HACKING	sim: punt WITH_DEVICES & tconfig.h support	10 years ago
configure	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
configure.ac	Bump to autoconf 2.69 and automake 1.15.1	8 years ago
configure.tgt	sim: or1k: add or1k target to sim	8 years ago