binutils-gdb

History

Tom Tromey 20a26f4e01 Finalize each cooked index separately After DWARF has been scanned, the cooked index code does a "finalization" step in a worker thread. This step combines all the index entries into a single master list, canonicalizes C++ names, and splits Ada names to synthesize package names. While this step is run in the background, gdb will wait for the results in some situations, and it turns out that this step can be slow. This is PR symtab/29105. This can be sped up by parallelizing, at a small memory cost. Now each index is finalized on its own, in a worker thread. The cost comes from name canonicalization: if a given non-canonical name is referred to by multiple indices, there will be N canonical copies (one per index) rather than just one. This requires changing the users of the index to iterate over multiple results. However, this is easily done by introducing a new "chained range" class. When run on gdb itself, the memory cost seems rather low -- on my current machine, "maint space 1" reports no change due to the patch. For performance testing, using "maint time 1" and "file" will not show correct results. That approach measures "time to next prompt", but because the patch only affects background work, this shouldn't (and doesn't) change. Instead, a simple way to make gdb wait for the results is to set a breakpoint. Before: $ /bin/time -f%e ~/gdb/install/bin/gdb -nx -q -batch \ -ex 'break main' /tmp/gdb Breakpoint 1 at 0x43ec30: file ../../binutils-gdb/gdb/gdb.c, line 28. 2.00 After: $ /bin/time -f%e ./gdb/gdb -nx -q -batch \ -ex 'break main' /tmp/gdb Breakpoint 1 at 0x43ec30: file ../../binutils-gdb/gdb/gdb.c, line 28. 0.65 Regression tested on x86-64 Fedora 34. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29105		4 years ago
..
abbrev-cache.c	Introduce DWARF abbrev cache	4 years ago
abbrev-cache.h	Add comments to dwarf2/abbrev-cache.h	4 years ago
abbrev.c	Fix method naming bug in new DWARF indexer	4 years ago
abbrev.h	Statically examine abbrev properties	4 years ago
attribute.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
attribute.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
comp-unit-head.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
comp-unit-head.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
cooked-index.c	Finalize each cooked index separately	4 years ago
cooked-index.h	Finalize each cooked index separately	4 years ago
cu.c	Delete DWARF psymtab code	4 years ago
cu.h	gdb: rename start_symtab/end_symtab to start_compunit_symtab/end_compunit_symtab	4 years ago
die.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
dwz.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
dwz.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
expr.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
expr.h	Fix some stale header names from dwarf files	4 years ago
file-and-dir.h	Add "fullname" handling to file_and_directory	4 years ago
frame-tailcall.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
frame-tailcall.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
frame.c	Unify gdb printf functions	4 years ago
frame.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
index-cache.c	Check OBJF_NOT_FILENAME in DWARF index code	4 years ago
index-cache.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
index-common.c	Add new overload of dwarf5_djb_hash	4 years ago
index-common.h	Add new overload of dwarf5_djb_hash	4 years ago
index-write.c	Fix crash when creating index from index	4 years ago
index-write.h	Rename write_psymtabs_to_index	4 years ago
leb.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
leb.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
line-header.c	gdb/dwarf: remove line_header::header_length field	4 years ago
line-header.h	gdb/dwarf: remove line_header::header_length field	4 years ago
loc.c	gdb: remove BLOCK_ENTRY_PC macro	4 years ago
loc.h	gdb/dwarf: pass an array of values to the dwarf evaluator	4 years ago
macro.c	gdb: change file_file_name to return an std::string	4 years ago
macro.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
mapped-index.h	Fix crash when creating index from index	4 years ago
public.h	Always use dwarf2_initialize_objfile	4 years ago
read.c	Accept functions with DW_AT_linkage_name present	4 years ago
read.h	Unify the DWARF index holders	4 years ago
sect-names.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
section.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
section.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
stringify.c	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
stringify.h	Automatic Copyright Year update after running gdb/copyright.py	4 years ago
tag.h	Fix .debug_names regression with new indexer	4 years ago