binutils-gdb

Commit Graph

Author	SHA1	Message	Date
YunQiang Su	cb81e84c72	MIPS: fix -gnuabi64 testsuite Test on: mips64-linux-gnuabi64 mips64el-linux-gnuabi64 mipsisa64-linux-gnuabi64 mipsisa64el-linux-gnuabi64 mipsisa64r2-linux-gnuabi64 mipsisa64r2el-linux-gnuabi64 mipsisa64r6-linux-gnuabi64 mipsisa64r6el-linux-gnuabi64	3 years ago
YunQiang Su	ffc528aed5	MIPS: fix r6 testsuites Introduce run_dump_test_o32l run_dump_test_n32l run_dump_test_n64l Which use `-march=from-abi` for pre-R6 testcases, like micromips/mips16e etc. For cases doesn't use run_dump_test_, we use -mips32r2 for micromips32 -mips1 for mips16-32 -march=from-abi for testcases to o32/n32/n64 both/all. Replace `addi` with `addiu` for some cases for both r6 and pre-R6. Introduce some new testcases for r6 with FPXX/FP64. Introduce new testcase: comdat-reloc-r6. Skip `default` in mips_arch_list_matching if triple is mipsisa, due to: 1)it will cannot match mipsr6@*.d: since mips32rN/mips64rN will always be used, it won't be a problem. 2)some test think -march=mips64rN will alway true for mipsisa64rN, which is not true now. This patch fix testsuite for all r6-default gnu triples: mipsisa32r6-linux-gnu mipsisa32r6el-linux-gnu mips-img-linux-gnu mipsel-img-linux-gnu mipsisa64r6-linux-gnu mipsisa64r6el-linux-gnu	3 years ago
YunQiang Su	be0d391f22	MIPS: default r6 if vendor is img This behavior is used by downstream toolchain since 2014. We also set the default ABI for mips-img-elf to O32. The previous value is NO_ABI, which is not good default ABI. We don't support mips64-img* due to GCC doesn't support it, and We believe that the multilib should be used for this case.	3 years ago
YunQiang Su	094025a30b	MIPS: gas: alter 64 or 32 for mipsisa triples if march is implicit When configure with triples mipsisa[32,64]rN[el,], the march value is pinned to a fix value if not given explicitly. for example 1) mipsisa32r6-linux-gnu -n32 xx.s will complains that: -march=mips32r6 is not compatible with the selected ABI 2) mipsisa64r2el-linux-gnu -o32 generates objects with 64bit CPU: ELF 32-bit LSB relocatable, MIPS, MIPS64 rel2 version 1 (SYSV) They are not good default behaviors: Let's alter the CPU info Since we are using these triples as a regular linux distributions, let's alter march according to ABI.	3 years ago
GDB Administrator	fa1ccf7895	Automatic date update in version.in	3 years ago
GDB Administrator	a366c78c1b	Automatic date update in version.in	3 years ago
Tom de Vries	33b5899fc0	[gdb] Fix typos Fix a few typos: - implemention -> implementation - convertion(s) -> conversion(s) - backlashes -> backslashes - signoring -> ignoring - (un)ambigious -> (un)ambiguous - occured -> occurred - hidding -> hiding - temporarilly -> temporarily - immediatelly -> immediately - sillyness -> silliness - similiar -> similar - porkuser -> pokeuser - thats -> that - alway -> always - supercede -> supersede - accomodate -> accommodate - aquire -> acquire - priveleged -> privileged - priviliged -> privileged - priviledges -> privileges - privilige -> privilege - recieve -> receive - (p)refered -> (p)referred - succesfully -> successfully - successfuly -> successfully - responsability -> responsibility - wether -> whether - wich -> which - disasbleable -> disableable - descriminant -> discriminant - construcstor -> constructor - underlaying -> underlying - underyling -> underlying - structureal -> structural - appearences -> appearances - terciarily -> tertiarily - resgisters -> registers - reacheable -> reachable - likelyhood -> likelihood - intepreter -> interpreter - disassemly -> disassembly - covnersion -> conversion - conviently -> conveniently - atttribute -> attribute - struction -> struct - resonable -> reasonable - popupated -> populated - namespaxe -> namespace - intialize -> initialize - identifer(s) -> identifier(s) - expection -> exception - exectuted -> executed - dungerous -> dangerous - dissapear -> disappear - completly -> completely - (inter)changable -> (inter)changeable - beakpoint -> breakpoint - automativ -> automatic - alocating -> allocating - agressive -> aggressive - writting -> writing - reguires -> requires - registed -> registered - recuding -> reducing - opeartor -> operator - ommitted -> omitted - modifing -> modifying - intances -> instances - imbedded -> embedded - gdbaarch -> gdbarch - exection -> execution - direcive -> directive - demanged -> demangled - decidely -> decidedly - argments -> arguments - agrument -> argument - amespace -> namespace - targtet -> target - supress(ed) -> suppress(ed) - startum -> stratum - squence -> sequence - prompty -> prompt - overlow -> overflow - memember -> member - languge -> language - geneate -> generate - funcion -> function - exising -> existing - dinking -> syncing - destroh -> destroy - clenaed -> cleaned - changep -> changedp (name of variable) - arround -> around - aproach -> approach - whould -> would - symobl -> symbol - recuse -> recurse - outter -> outer - freeds -> frees - contex -> context Tested on x86_64-linux. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	343704a6d7	[gdb/tdep] Fix typo in debug message In microblaze_analyze_prologue in gdb/microblaze-tdep.c I came across: ... microblaze_debug ("got addi r1,r1,%d; contnuing\n", imm); ... Fix this by using "continuing". Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	2242afe896	[gdb/python] Fix doc string of valpy_const_value In gdb/python/py-value.c, in the value_object_methods array I noticed: ... { "const_value", valpy_const_value, METH_NOARGS, "Return a 'const' qualied version of the same value." }, ... Fix the qualied -> qualified typo. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	26236df340	[gdb/guile] Fix doc string for value-optimized-out? In gdb/guile/scm-value.c, I noticed in the value_functions array initializer: ... { "value-optimized-out?", 1, 0, 0, as_a_scm_t_subr (gdbscm_value_optimized_out_p), "\ Return #t if the value has been optimizd out." }, ... There's a typo in the doc string. Fix this by using "optimized". Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	2829d6da38	[gdb/tui] Fix help text of show tui tab-width I noticed: ... (gdb) help show tui tab-width Show the tab witdh, in characters, for the TUI. This variable controls how many spaces are used to display a tab character. ... a typo: "witdh". Fix this by using "width" instead. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	8def33e68c	[gdb/cli] Fix help text of maint info target-sections I noticed a typo: ... (gdb) help maint info target-sections List GDB's internal section table. Print the current targets section list. This is a sub-set of all sections, from all objects currently loaded. Usually the ALLOC sectoins. ... Fix this by using "sections". Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	a383ee4099	[gdb/cli] Fix help text of maint set ignore-prologue-end-flag I noticed here: ... (gdb) help maint set ignore-prologue-end-flag Set if the PROLOGUE-END flag is ignored. The PROLOGUE-END flag from the line-table entries is used to place \ breakpoints past the prologue of functions. Disabeling its use use forces \ the use of prologue scanners. ... a typo in "Disabeling" and accidental word repetition "use use". Fix by replacing with "Disabling" and "use". Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	2595faaa1c	[gdb/compile] Fix typo in debug message In compile_object_load in gdb/compile/compile-object-load.c I came across: ... "Connectiong ELF symbol \"%s\" to the .toc section (%s)\n", ... Fix this typo by using "Connecting" instead. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	9e92dbaa0c	[gdbserver] Fix typo in debug message I noticed in emit_ops_insns in gdbserver/linux-aarch64-low.cc: ... threads_debug_printf ("Adding %d instrucions at %s", ... Fix the typo by using "instructions" instead. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	6d280fed3d	[gdb/ada] Fix argument name misspelling Two functions use the argument name bounds_prefered_p. This misspells "preferred". Fix this by using bounds_preferred_p instead. Tested on x86_64-linux. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Alan Modra	89c70cd358	Re: loongarch readelf support Another segfault. * readelf.c (target_specific_reloc_handling): Sanity check loongarch reloc r_offset.	3 years ago
Alan Modra	c6e6e3ab2b	Re: More ecoff sanity checks Yet another fuzzer fix. * ecoff.c (ecoff_slurp_symbolic_header <FIX>): Zero counts when associated pointer is zero. (_bfd_ecoff_slurp_symbolic_info): Remove now unnecessary check.	3 years ago
GDB Administrator	26cc2053e2	Automatic date update in version.in	3 years ago
Luis Machado	21b9239b70	[AArch64] Fix architecture debug version constant thinkos Caught this during emulator testing. Fix the constants. They should be 0xa and 0xb as opposed to 0x10 and 0x11. There was a thinko while defining them. Obvious enough. Tested on aarch64-linux Ubuntu 20.04/22.04.	3 years ago
Alan Modra	63188cb5c3	Re: bfd_close and target free_cached_memory _bfd_delete_bfd can be called early, before the target xvec is set up. * opncls.c (_bfd_delete_bfd): Don't segfault on NULL xvec.	3 years ago
Alan Modra	e0ce6dde97	Re: More ecoff sanity checks Another fix for fuzzed object files, exhibiting as a segfault in nm.c filter_symbols when accessing a symbol name. * ecoff.c (_bfd_ecoff_slurp_symbol_table): Sanity check fdr_ptr->issBase, and tighten sym.iss check.	3 years ago
Alan Modra	74a965d8e0	loongarch readelf support This fixes two buffer overflows found by fuzzers. * readelf.c (target_specific_reloc_handling): Sanity check loongarch reloc symbol index. Don't apply reloc after errors. Reduce translation work of "invalid symbol index" error message.	3 years ago
Alan Modra	56e4ccc924	Minor objcopy optimisation for copy_relocations_in_section * objcopy (copy_relocations_in_section): Don't read the relocs for STRIP_ALL if keep_specific_htab is empty.	3 years ago
GDB Administrator	cf6522cb2f	Automatic date update in version.in	3 years ago
Indu Bhagat	d987df5c95	libsframe: avoid using magic number Define a new constant for the maximum number of stack offsets handled in libsframe, and use it. Note that the SFrame format does not define such a constant (limit). This is an implmentation-defined constant in libsframe. include/ * sframe-api.h (MAX_NUM_STACK_OFFSETS): New definition. libsframe/ * sframe.c (sframe_fre_sanity_check_p): Use it.	3 years ago
Indu Bhagat	a5ffdcafc7	libsframe: minor fixups in flip_fre related functions libsframe/ * sframe.c (flip_fre_start_address): Remove unnecessary type cast. Use uint16_t instead of unsigned short. (flip_fre_stack_offsets): Likewise.	3 years ago
Jim Wilson	ec2260af61	RISC-V: PR30449, Add lga assembler macro support. Originally discussion, https://github.com/riscv/riscv-isa-manual/pull/539 Added new load address pseudo instruction which is always expanded to GOT access, no matter the .option rvc is set or not. gas/ PR 30449 * config/tc-riscv.c (macro): Add M_LGA support. * testsuite/gas/riscv/la-variants.d: New. * testsuite/gas/riscv/la-variants.s: New. include/ PR 30449 * opcode/riscv.h (M_LGA): New. opcodes/ PR 30449 * riscv-opc.c (riscv_opcodes): Add lga support.	3 years ago
Nelson Chu	20ef84ed2a	[PR ld/22263][PR ld/24676] RISC-V: Avoid spurious R_RISCV_NONE for TLS GD/IE. For TLS GD/IE, add the same condition with the relocate_section in the allocate_dynrelocs, to make sure we won't reserve redundant spaces for dynamic relocations since the conservative estimatation. After applying this patch, ld seems no longer generate the spurious R_RISCV_NONE for pr22263-1 test, and the test in pr24676. bfd/ PR ld/22263 PR ld/24676 * elfnn-riscv.c (RISCV_TLS_GD_IE_NEED_DYN_RELOC): New defined. Set NEED_RELOC to true if TLS GD/IE needs dynamic relocations, and INDX will be the dynamic index. (allocate_dynrelocs): Don't reserve extra spaces in the rela.got if RISCV_TLS_GD_IE_NEED_DYN_RELOC set need_reloc to false. This condition needs to be same as relocate_section. (relocate_section): Likewise, use the same condition as allocate_dynrelocs.	3 years ago
Alan Modra	6313825cbf	Harden PowerPC64 OPD handling against fuzzers PowerPC64 ELFv1 object files should have at most one .opd section, and OPD handling in elf64-ppc.c makes use of this fact by caching some .opd section info in the per-object bfd.tdata. This was done to avoid another word in the target specific section data. Of course, fuzzers don't respect the ABI, and even non-malicious users can accidentally create multiple .opd sections. So it is better to avoid possible buffer overflows and other confusion when OPD handling for a second .opd section references data for the first .opd section, by keeping the data per-section. The patch also fixes a memory leak, and a corner case where I think we could hit an assertion in opd_entry_value or read out of bounds in ppc64_elf_branch_reloc doing a final link producing non-ppc64 output. (It's a really rare corner case because not only would you need to be linking ppc64 objects to non-ppc64 output, you'd also need a branch reloc symbol to be defined in a .opd section of a non-ppc64 input.) * elf64-ppc.c (is_ppc64_elf): Move earlier in file. (ppc64_elf_branch_reloc): Check symbol bfd before accessing ppc64 elf specific data structures. (struct ppc64_elf_obj_tdata): Move opd union.. (struct _ppc64_elf_section_data): ..to here. (ppc64_elf_before_check_relocs): Allow for opd sec_type already set to sec_opd. (ppc64_elf_check_relocs): Only set sec_type to sec_toc when unset. Error for unexpected toc relocs. (opd_entry_value): Return -1 when non-ppc64 rather than asserting. Check and set sec_type too. Adjust for changed location of contents and relocs. (ppc64_elf_relocate_section): Adjust for changed location of cached .opd relocs. (ppc64_elf_free_cached_info): New function. (bfd_elf64_bfd_free_cached_info): Define.	3 years ago
Alan Modra	8261abd513	bfd_close and target free_cached_memory bfd_free_cached_info is used in just one place in archive.c, which means most times we reach bfd_close the function isn't called. On the other hand, if bfd_free_cached_info is called we can't do much on the bfd since it loses all its obj_alloc memory. This restricts what can be done in a target _close_and_cleanup. In particular you can't look at sections, which leads to duplication of code in target close_and_cleanup and free_cached_info, eg. elfnn-aarch64.c. * opncls.c (_bfd_delete_bfd): Call bfd_free_cached_info. * elfnn-aarch64.c (elfNN_aarch64_close_and_cleanup): Delete. (bfd_elfNN_close_and_cleanup): Don't define. * som.c (som_bfd_free_cached_info): Don't call _bfd_generic_close_and_cleanup here. (som_close_and_cleanup): Define as _bfd_generic_close_and_cleanup.	3 years ago
Alan Modra	90fd5049bd	section_by_target_index memory leak The rs6000 backend can call coff_section_from_bfd_index from its object_p function via coff_set_alignment_hook. If the object doesn't match, or another target matches too, then the hash table needs to be freed via a cleanup. * coffgen.c (coff_object_cleanup): New function. (coff_real_object_p): Return coff_object_cleanup, and call on failure path. Move declaration to.. * libcoff-in.h: ..here. (coff_object_cleanup): Declare. * coff-stgo32.c (go32exe_cleanup): Call coff_object_cleanup. (go32exe_check_format): Adjust assertion. * libcoff.h: Regenerate.	3 years ago
Alan Modra	d18f60c747	Remove BFD_FAIL in cpu-sh.c The assertions in cpu-sh.c can be triggered by passing bogus values in disassemble_info.mach. This doesn't cause any bfd misbehaviour. * cpu-sh.c (sh_get_arch_from_bfd_mach): Remove BFD_FAIL. (sh_get_arch_up_from_bfd_mach): Likewise.	3 years ago
GDB Administrator	f38f7ef965	Automatic date update in version.in	3 years ago
Vladimir Mezentsev	dd8a4e320b	gprofng: Fix -Wsign-compare warning gprofng/ChangeLog 2023-05-25 Vladimir Mezentsev <vladimir.mezentsev@oracle.com> PR gprofng/30490 * src/LoadObject.cc: Fix -Wsign-compare warning.	3 years ago
Vladimir Mezentsev	defb734195	gprofng: 29470 The test suite should be made more flexible I add two new targets (check-extra, check-install) for gprofng testing: `make check` runs sanity testing for gprofng and takes ~30 secunds. `make check-extra` runs all gprofng tests and takes ~20 minutus. `make check-install` runs all gprofng tests and uses gprofng installation. On aarch64, there are unwind problems in libgp-collector.so. I set ACCT_FILTER to temporarily ignore problematic functions. gprofng/ChangeLog 2023-05-25 Vladimir Mezentsev <vladimir.mezentsev@oracle.com> PR gprofng/29470 * Makefile.am: Add check-extra, check-install. * Makefile.in: Rebuild * testsuite/config/default.exp: Set the GPROFNG variable. * testsuite/gprofng.display/display.exp: Updated the test list. * testsuite/gprofng.display/jsynprog/Intface.java: Correct copyright. * testsuite/gprofng.display/jsynprog/Launcher.java: Likewise. * testsuite/gprofng.display/jsynprog/Makefile: Likewise. * testsuite/gprofng.display/jsynprog/Routine.java: Likewise. * testsuite/gprofng.display/jsynprog/Sub_Routine.java: Likewise. * testsuite/gprofng.display/jsynprog/cloop.cc: Likewise. * testsuite/gprofng.display/jsynprog/jsynprog.h: Likewise. * testsuite/gprofng.display/jsynprog/jsynprog.java: Correct copyright. Add the -j option to run the selected functions. * testsuite/gprofng.display/synprog/check_results.pl: Remove unused environment variable. * testsuite/gprofng.display/synprog/synprog.c: Updated DEFAULT_COMMAND. * testsuite/lib/Makefile.skel: Apply $(ACCT_FILTER). * testsuite/lib/acct.pm: Ignore errors when $(ACCT_FILTER) is set. * testsuite/lib/display-lib.exp: Add TARGET_FLAGS in make_args.	3 years ago
Tom Tromey	739f67599a	Improve MI -dprintf-insert documentation I found the documentation for -dprintf-insert a bit unclear. It didn't mention the possibility of multiple arguments, and I also noticed that it implied that the format parameter is optional, which it is not. While looking into this I also noticed a few comments in the implementation that could also be improved. Then, I noticed a repeated call to strlen in a loop condition, so I fixed this up as well. Reviewed-By: Eli Zaretskii <eliz@gnu.org>	3 years ago
Tom Tromey	20fcd17479	Pass correct name to @value in gdb.texinfo I noticed a couple instance of this warning when rebuilding the gdb info files: warning: undefined flag: GDB The problem is that the wrong argument was passed to @value. This patch fixes the problem.	3 years ago
Tom de Vries	0b1cae3530	[gdb/testsuite] Fix gdb.tui/wrap-line.exp with --disable-tui When running the test-case gdb.tui/wrap-line.exp with a build configured with --disable-tui, we run into: ... (gdb) PASS: gdb.tui/wrap-line.exp: width-hard-coded: set width 50 tui new-layout command-layout cmd 1^M Undefined command: "tui". Try "help".^M (gdb) ERROR: Undefined command "tui new-layout command-layout cmd 1". ... Fix this by guarding the command with allow_tui_tests. Tested on x86_64-linux.	3 years ago
Tom de Vries	6e9bcaad3f	[gdb/testsuite] Fix gdb.tui/pr30056.exp for native-extended-gdbserver When running test-case gdb.tui/pr30056.exp with target board native-extended-gdbserver, I run into: ... Quit^[[K^M^[[B(gdb) PASS: gdb.tui/pr30056.exp: Control-C Remote debugging from host ::1, port 38810^M ^M(failed reverse-i-search)`xyz': ^M(gdb) target extended-remote \ localhost:2346^[[7GWARNING: Timed out waiting for EOF in server after \ monitor exit ... This is due to the fact that ^C doesn't abort the reverse-i-search. This appears to be due to a readline problem. A PR is open about this: PR cli/30498. Add a KFAIL for the PR, and ensure that the isearch is aborted by using ^G, such that we have a responsive prompt to handle the "monitor exit" command that native-extended-gdbserver issues. Tested on x86_64-linux.	3 years ago
Tristan Gingold	768d1d879b	pe/coff - add support for base64 encoded long section names PR 30444 * coffcode.h (coff_write_object_contents): Handle base64 encoding on PE. Also check for too large string table. * coffgen.c (extract_long_section_name): New function extracted from ... (make_a_section_from_file): ... here. Add support for base64 long section names. (decode_base64): New function.	3 years ago
Nick Clifton	a15891aaea	Fix printf formating issues in elfxx-loongarch64.c	3 years ago
Felix Willgerodt	e9683acf5e	python, btrace: Fix some small formatting issues. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
Tom de Vries	9d66d71cdd	[gdb/tui] Fix fingerprint for cmd-only layout I added a cmd-only layout: ... (gdb) tui new-layout cmd cmd 1 ... and set it: ... (gdb) layout cmd ... which gave me the expect result: only the cmd window in the screen. However, after going back to layout src: ... (gdb) layout src ... I got a source window with only one line in it, and the cmd window taking most of the screen. I traced this back to tui_set_layout, where for both the old and the new layout the fingerprint of the cmd window in the layout is taken. If the fingerprint is the same, an effort will be done to preserve the command window size. The fingerprint is "VC" for both the old (cmd) and new (src) layouts, which explains the behaviour. I think this is essentially a bug in the finger print calculation, and it should be "C" for the cmd layout. Fix this by not adding a V or H in the fingerprint if the list size is one. Tested on x86_64-linux. Reviewed-By: Tom Tromey <tom@tromey.com>	3 years ago
GDB Administrator	2fee907cfd	Automatic date update in version.in	3 years ago
Andrew Burgess	901682e4a4	gdb: add support for %V to printf command This commit adds a new format for the printf and dprintf commands: '%V'. This new format takes any GDB expression and formats it as a string, just as GDB would for a 'print' command, e.g.: (gdb) print a1 $a = {2, 4, 6, 8, 10, 12, 14, 16, 18, 20} (gdb) printf "%V\n", a1 {2, 4, 6, 8, 10, 12, 14, 16, 18, 20} (gdb) It is also possible to pass the same options to %V as you might pass to the print command, e.g.: (gdb) print -elements 3 -- a1 $4 = {2, 4, 6...} (gdb) printf "%V[-elements 3]\n", a1 {2, 4, 6...} (gdb) This new feature would effectively replace an existing feature of GDB, the $_as_string builtin convenience function. However, the $_as_string function has a few problems which this new feature solves: 1. $_as_string doesn't currently work when the inferior is not running, e.g: (gdb) printf "%s", $_as_string(a1) You can't do that without a process to debug. (gdb) The reason for this is that $_as_string returns a value object with string type. When we try to print this we call value_as_address, which ends up trying to push the string into the inferior's address space. Clearly we could solve this problem, the string data exists in GDB, so there's no reason why we have to push it into the inferior, but this is an existing problem that would need solving. 2. $_as_string suffers from the fact that C degrades arrays to pointers, e.g.: (gdb) printf "%s\n", $_as_string(a1) 0x404260 <a1> (gdb) The implementation of $_as_string is passed a gdb.Value object that is a pointer, it doesn't understand that it's actually an array. Solving this would be harder than issue #1 I think. The whole array to pointer transformation is part of our expression evaluation. And in most cases this is exactly what we want. It's not clear to me how we'd (easily) tell GDB that we didn't want this reduction in _some_ cases. But I'm sure this is solvable if we really wanted to. 3. $_as_string is a gdb.Function sub-class, and as such is passed gdb.Value objects. There's no super convenient way to pass formatting options to $_as_string. By this I mean that the new %V feature supports print formatting options. Ideally, we might want to add this feature to $_as_string, we might imagine it working something like: (gdb) printf "%s\n", $_as_string(a1, elements = 3, array_indexes = True) where the first item is the value to print, while the remaining options are the print formatting options. However, this relies on Python calling syntax, which isn't something that convenience functions handle. We could possibly rely on strictly positional arguments, like: (gdb) printf "%s\n", $_as_string(a1, 3, 1) But that's clearly terrible as there's far more print formatting options, and if you needed to set the 9th option you'd need to fill in all the previous options. And right now, the only way to pass these options to a gdb.Function is to have GDB first convert them all into gdb.Value objects, which is really overkill for what we want. The new %V format solves all these problems: the string is computed and printed entirely on the GDB side, we are able to print arrays as actual arrays rather than pointers, and we can pass named format arguments. Finally, the $_as_string is sold in the manual as allowing users to print the string representation of flag enums, so given: enum flags { FLAG_A = (1 << 0), FLAG_B = (1 << 1), FLAG_C = (1 << 1) }; enum flags ff = FLAG_B; We can: (gdb) printf "%s\n", $_as_string(ff) FLAG_B This works just fine with %V too: (gdb) printf "%V\n", ff FLAG_B So all functionality of $_as_string is replaced by %V. I'm not proposing to remove $_as_string, there might be users currently depending on it, but I am proposing that we don't push $_as_string in the documentation. As %V is a feature of printf, GDB's dprintf breakpoints naturally gain access to this feature too. dprintf breakpoints can be operated in three different styles 'gdb' (use GDB's printf), 'call' (call a function in the inferior), or 'agent' (perform the dprintf on the remote). The use of '%V' will work just fine when dprintf-style is 'gdb'. When dprintf-style is 'call' the format string and arguments are passed to an inferior function (printf by default). In this case GDB doesn't prevent use of '%V', but the documentation makes it clear that support for '%V' will depend on the inferior function being called. I chose this approach because the current implementation doesn't place any restrictions on the format string when operating in 'call' style. That is, the user might already be calling a function that supports custom print format specifiers (maybe including '%V') so, I claim, it would be wrong to block use of '%V' in this case. The documentation does make it clear that users shouldn't expect this to "just work" though. When dprintf-style is 'agent' then GDB does no support the use of '%V' (right now). This is handled at the point when GDB tries to process the format string and send the dprintf command to the remote, here's an example: Reading symbols from /tmp/hello.x... (gdb) dprintf call_me, "%V", a1 Dprintf 1 at 0x401152: file /tmp/hello.c, line 8. (gdb) set sysroot / (gdb) target remote \| gdbserver --once - /tmp/hello.x Remote debugging using \| gdbserver --once - /tmp/hello.x stdin/stdout redirected Process /tmp/hello.x created; pid = 3088822 Remote debugging using stdio Reading symbols from /lib64/ld-linux-x86-64.so.2... (No debugging symbols found in /lib64/ld-linux-x86-64.so.2) 0x00007ffff7fd3110 in _start () from /lib64/ld-linux-x86-64.so.2 (gdb) set dprintf-style agent (gdb) c Continuing. Unrecognized format specifier 'V' in printf Command aborted. (gdb) This is exactly how GDB would handle any other invalid format specifier, for example: Reading symbols from /tmp/hello.x... (gdb) dprintf call_me, "%Q", a1 Dprintf 1 at 0x401152: file /tmp/hello.c, line 8. (gdb) set sysroot / (gdb) target remote \| gdbserver --once - /tmp/hello.x Remote debugging using \| gdbserver --once - /tmp/hello.x stdin/stdout redirected Process /tmp/hello.x created; pid = 3089193 Remote debugging using stdio Reading symbols from /lib64/ld-linux-x86-64.so.2... (No debugging symbols found in /lib64/ld-linux-x86-64.so.2) 0x00007ffff7fd3110 in _start () from /lib64/ld-linux-x86-64.so.2 (gdb) set dprintf-style agent (gdb) c Continuing. Unrecognized format specifier 'Q' in printf Command aborted. (gdb) The error message isn't the greatest, but improving that can be put off for another day I hope. Reviewed-By: Eli Zaretskii <eliz@gnu.org> Acked-By: Simon Marchi <simon.marchi@efficios.com>	3 years ago
Simon Marchi	ec517d1040	gdb: add interp::on_memory_changed method Same idea as previous patches, but for memory_changed. Change-Id: Ic19f20c24d8a6431d4a89c5625e8ef4898f76e82	3 years ago
Simon Marchi	3d654fa72d	gdb: add interp::on_param_changed method Same idea as previous patches, but for command_param_changed. Change-Id: I7c2196343423360da05f016f8ffa871c064092bb	3 years ago
Simon Marchi	19081eb5f1	gdb: add interp::on_breakpoint_modified method Same idea as previous patches, but for breakpoint_modified. Change-Id: I4f0a9edea912de431e32451d74224b2022a7c328	3 years ago
Simon Marchi	e4239559f4	gdb: add interp::on_breakpoint_deleted method Same idea as previous patches, but for breakpoint_deleted. Change-Id: I59c231ce963491bb1eee1432ee1090138f09e19c	3 years ago

1 2 3 4 5 ...

114871 Commits (cb81e84c72933a7fad10b75b7e270d92d8d65251) All Branches Search

114871 Commits (cb81e84c72933a7fad10b75b7e270d92d8d65251)

All Branches