Remove remnants of partial DIEs from DWARF reader

When rewriting the DWARF scanner, I forgot to remove
dwarf2_cu::load_all_dies and dwarf2_cu::partial_dies.  This patch
corrects the oversight and fixes up a couple other spots that mention
partial DIEs, which no longer exist.

Approved-By: Tom de Vries <tdevries@suse.de>

gdb/dwarf2/cu.c

@@ -42,8 +42,7 @@ dwarf2_cu::dwarf2_cu (dwarf2_per_cu_data *per_cu,
     producer_is_clang (false),
     producer_is_gas_lt_2_38 (false),
     producer_is_gas_2_39 (false),
-    processing_has_namespace_info (false),
+    processing_has_namespace_info (false)
-    load_all_dies (false)
 {
 }
 

gdb/dwarf2/cu.h

@@ -136,12 +136,8 @@ public:
      distinguish these in buildsym.c.  */
   struct pending **list_in_scope = nullptr;
 
-  /* Hash table holding all the loaded partial DIEs
+  /* Storage for things with the same lifetime as this read-in
-     with partial_die->offset.SECT_OFF as hash.  */
+     compilation unit. */
-  htab_t partial_dies = nullptr;
-
-  /* Storage for things with the same lifetime as this read-in compilation
-     unit, including partial DIEs.  */
   auto_obstack comp_unit_obstack;
 
   /* Backlink to our per_cu entry.  */
@@ -274,12 +270,6 @@ public:
 
   bool processing_has_namespace_info : 1;
 
-  /* This flag will be set when reading partial DIEs if we need to load
-     absolutely all DIEs for this compilation unit, instead of just the ones
-     we think are interesting.  It gets set if we look for a DIE in the
-     hash table and don't find it.  */
-  bool load_all_dies : 1;
-
   /* Get the buildsym_compunit for this CU.  */
   buildsym_compunit *get_builder ();
 };

gdb/dwarf2/read.c

@@ -25,8 +25,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 /* FIXME: Various die-reading functions need to be more careful with
-   reading off the end of the section.
+   reading off the end of the section.  */
-   E.g., load_partial_dies, read_partial_die.  */
 
 #include "defs.h"
 #include "dwarf2/read.h"
@@ -21475,7 +21474,7 @@ dwarf2_find_containing_comp_unit (sect_offset sect_off,
   if (this_cu->is_dwz != offset_in_dwz || this_cu->sect_off > sect_off)
     {
       if (low == 0 || this_cu->is_dwz != offset_in_dwz)
-	error (_("Dwarf Error: could not find partial DIE containing "
+	error (_("Dwarf Error: could not find CU containing "
 	       "offset %s [in module %s]"),
 	       sect_offset_str (sect_off),
 	       bfd_get_filename (per_bfd->obfd));