Browse Source

PR28448, Memory leak in function add_symbols(plugin.c)

PR 28448
	* plugin.c (add_symbols): bfd_alloc memory for symptrs.  Check
	bfd_make_empty_symbol return.
master
Alan Modra 2 years ago
parent
commit
19bfbfa665
  1. 6
      ld/plugin.c

6
ld/plugin.c

@ -506,7 +506,9 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms)
int n;
ASSERT (called_plugin);
symptrs = xmalloc (nsyms * sizeof *symptrs);
symptrs = bfd_alloc (abfd, nsyms * sizeof *symptrs);
if (symptrs == NULL)
return LDPS_ERR;
for (n = 0; n < nsyms; n++)
{
enum ld_plugin_status rv;
@ -514,6 +516,8 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms)
bfdsym = bfd_make_empty_symbol (abfd);
symptrs[n] = bfdsym;
if (bfdsym == NULL)
return LDPS_ERR;
rv = asymbol_from_plugin_symbol (abfd, bfdsym, syms + n);
if (rv != LDPS_OK)
return rv;

Loading…
Cancel
Save