riscv
/
binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

Remove process_stratum_target::hostio_last_error abstraction 

Now that the WinCE port is gone, all ports map host I/O errors from
errno, so this abstraction is no longer necessary.

Basically undoes:
  https://sourceware.org/pipermail/gdb-patches/2008-January/055511.html
  https://sourceware.org/pipermail/gdb-patches/attachments/20080131/f44e7012/attachment.bin

gdbserver/ChangeLog:

	* Makefile.in (SFILES): Remove hostio-errno.cc.
	* configure: Regenerate.
	* configure.ac (GDBSERVER_DEPFILES): No longer add
	$srv_hostio_err_objs.
	* configure.srv (srv_hostio_err_objs): Delete.
	* hostio-errno.cc: Delete.
	* hostio.cc (hostio_error): Inline hostio_last_error_from_errno
	here.
	* hostio.h (hostio_last_error_from_errno): Delete.
	* target.cc (process_stratum_target::hostio_last_error): Delete.
	* target.h (class process_stratum_target) <hostio_last_error>:
	Delete.
binutils-2_37-branch
Pedro Alves 5 years ago
parent
d2f1139ef0
commit
0256da25c0
10 changed files with 22 additions and 61 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 15
      gdbserver/ChangeLog
  2. 1
      gdbserver/Makefile.in
  3. 2
      gdbserver/configure
  4. 2
      gdbserver/configure.ac
  5. 5
      gdbserver/configure.srv
  6. 36
      gdbserver/hostio-errno.cc
  7. 8
      gdbserver/hostio.cc
  8. 4
      gdbserver/hostio.h
  9. 6
      gdbserver/target.cc
  10. 4
      gdbserver/target.h

15
gdbserver/ChangeLog
View File

@ -1,3 +1,18 @@
2021-04-13 Pedro Alves <pedro@palves.net>
* Makefile.in (SFILES): Remove hostio-errno.cc.
* configure: Regenerate.
* configure.ac (GDBSERVER_DEPFILES): No longer add
$srv_hostio_err_objs.
* configure.srv (srv_hostio_err_objs): Delete.
* hostio-errno.cc: Delete.
* hostio.cc (hostio_error): Inline hostio_last_error_from_errno
here.
* hostio.h (hostio_last_error_from_errno): Delete.
* target.cc (process_stratum_target::hostio_last_error): Delete.
* target.h (class process_stratum_target) <hostio_last_error>:
Delete.
2021-04-12 Simon Marchi <simon.marchi@polymtl.ca>
* win32-low.cc: Remove all code guarded by _WIN32_WCE.

1
gdbserver/Makefile.in
View File

@ -186,7 +186,6 @@ SFILES = \
$(srcdir)/dll.cc \
$(srcdir)/gdbreplay.cc \
$(srcdir)/hostio.cc \
$(srcdir)/hostio-errno.cc \
$(srcdir)/i387-fp.cc \
$(srcdir)/inferiors.cc \
$(srcdir)/linux-aarch64-low.cc \

2
gdbserver/configure
View File

@ -10633,7 +10633,7 @@ $as_echo "#define USE_XML 1" >>confdefs.h
done
fi
GDBSERVER_DEPFILES="$srv_regobj $srv_tgtobj $srv_hostio_err_objs $srv_thread_depfiles"
GDBSERVER_DEPFILES="$srv_regobj $srv_tgtobj $srv_thread_depfiles"
GDBSERVER_LIBS="$srv_libs"
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether the target supports __sync_*_compare_and_swap" >&5

2
gdbserver/configure.ac
View File

@ -379,7 +379,7 @@ if test "$srv_xmlfiles" != ""; then
done
fi
GDBSERVER_DEPFILES="$srv_regobj $srv_tgtobj $srv_hostio_err_objs $srv_thread_depfiles"
GDBSERVER_DEPFILES="$srv_regobj $srv_tgtobj $srv_thread_depfiles"
GDBSERVER_LIBS="$srv_libs"
dnl Check whether the target supports __sync_*_compare_and_swap.

5
gdbserver/configure.srv
View File

@ -8,8 +8,6 @@
# srv_regobj The register protocol appropriate for this target.
# srv_tgtobj Any other target-specific modules appropriate
# for this target.
# srv_hostio_err The object implementing the hostio_last_error
# target method.
# srv_xmlfiles All XML files which should be available for
# gdbserver in this configuration.
# ipa_obj Any other target-specific modules appropriate
@ -24,9 +22,6 @@
# srv_linux_usrregs Set to "yes" if we can get at registers via
# PTRACE_PEEKUSR / PTRACE_POKEUSR.
# Default hostio_last_error implementation
srv_hostio_err_objs="hostio-errno.o"
ipa_ppc_linux_regobj="powerpc-32l-ipa.o powerpc-altivec32l-ipa.o powerpc-vsx32l-ipa.o powerpc-isa205-32l-ipa.o powerpc-isa205-altivec32l-ipa.o powerpc-isa205-vsx32l-ipa.o powerpc-isa205-ppr-dscr-vsx32l-ipa.o powerpc-isa207-vsx32l-ipa.o powerpc-isa207-htm-vsx32l-ipa.o powerpc-e500l-ipa.o powerpc-64l-ipa.o powerpc-altivec64l-ipa.o powerpc-vsx64l-ipa.o powerpc-isa205-64l-ipa.o powerpc-isa205-altivec64l-ipa.o powerpc-isa205-vsx64l-ipa.o powerpc-isa205-ppr-dscr-vsx64l-ipa.o powerpc-isa207-vsx64l-ipa.o powerpc-isa207-htm-vsx64l-ipa.o"
# Linux object files. This is so we don't have to repeat

36
gdbserver/hostio-errno.cc
View File

@ -1,36 +0,0 @@
/* Host file transfer support for gdbserver.
Copyright (C) 2007-2021 Free Software Foundation, Inc.
Contributed by CodeSourcery.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
/* This file implements the hostio_last_error target callback
on top of errno. */
#include "server.h"
#include "hostio.h"
#include "gdbsupport/fileio.h"
void
hostio_last_error_from_errno (char *buf)
{
int error = errno;
int fileio_error = host_to_fileio_error (error);
sprintf (buf, "F-1,%x", fileio_error);
}

8
gdbserver/hostio.cc
View File

@ -191,12 +191,14 @@ require_valid_fd (int fd)
return -1;
}
/* Fill in own_buf with the last hostio error packet, however it
suitable for the target. */
/* Fill BUF with an hostio error packet representing the last hostio
error, from errno. */
static void
hostio_error (char *own_buf)
{
the_target->hostio_last_error (own_buf);
int fileio_error = host_to_fileio_error (errno);
sprintf (own_buf, "F-1,%x", fileio_error);
}
static void

4
gdbserver/hostio.h
View File

@ -22,10 +22,6 @@
/* Per-connection setup. */
extern void hostio_handle_new_gdb_connection (void);
/* Functions from hostio.c. */
extern int handle_vFile (char *, int, int *);
/* Functions from hostio-errno.c. */
extern void hostio_last_error_from_errno (char *own_buf);
#endif /* GDBSERVER_HOSTIO_H */

6
gdbserver/target.cc
View File

@ -505,12 +505,6 @@ process_stratum_target::get_tls_address (thread_info *thread,
gdb_assert_not_reached ("target op get_tls_address not supported");
}
void
process_stratum_target::hostio_last_error (char *buf)
{
hostio_last_error_from_errno (buf);
}
bool
process_stratum_target::supports_qxfer_osdata ()
{

4
gdbserver/target.h
View File

@ -256,10 +256,6 @@ public:
virtual int get_tls_address (thread_info *thread, CORE_ADDR offset,
CORE_ADDR load_module, CORE_ADDR *address);
/* Fill BUF with an hostio error packet representing the last hostio
error. */
virtual void hostio_last_error (char *buf);
/* Return true if the qxfer_osdata target op is supported. */
virtual bool supports_qxfer_osdata ();

Write Preview
Loading…
Cancel
Save