Browse Source

server: return empty slice on empty `/api/embed` request (#5713)

* server: return empty slice on empty `/api/embed` request

* fix tests
royh-openai-suffixdocs
Jeffrey Morgan 2 years ago
committed by GitHub
parent
commit
7ac6d462ec
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 2
      api/types.go
  2. 8
      server/routes_test.go

2
api/types.go

@ -206,7 +206,7 @@ type EmbedRequest struct {
// EmbedResponse is the response from [Client.Embed].
type EmbedResponse struct {
Model string `json:"model"`
Embeddings [][]float32 `json:"embeddings,omitempty"`
Embeddings [][]float32 `json:"embeddings"`
}
// EmbeddingRequest is the request passed to [Client.Embeddings].

8
server/routes_test.go

@ -306,8 +306,12 @@ func Test_Routes(t *testing.T) {
t.Fatalf("expected model t-bone, got %s", embedResp.Model)
}
if embedResp.Embeddings != nil {
t.Fatalf("expected embeddings to be nil, got %v", embedResp.Embeddings)
if embedResp.Embeddings == nil {
t.Fatalf("expected embeddings to not be nil, got %v", embedResp.Embeddings)
}
if len(embedResp.Embeddings) != 0 {
t.Fatalf("expected embeddings to be empty, got %v", embedResp.Embeddings)
}
},
},

Loading…
Cancel
Save